lmoskala/SSLClient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: fix infinite recursion bug with the ESP32 when BearSSL wasn't ready to send

Browse source
This commit is contained in:
Noah Laptop 2021-03-21 16:15:57 -07:00
parent 1f9c1f9088
commit cbb4493876
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/SSLClient.cpp
View file

@ -96,10 +96,19 @@ size_t SSLClient::write(const uint8_t *buf, size_t size) {
if (m_debug >= DebugLevel::SSL_DUMP) Serial.write(buf, size); if (m_debug >= DebugLevel::SSL_DUMP) Serial.write(buf, size);
// check if the socket is still open and such // check if the socket is still open and such
if (!m_soft_connected(func_name) || !buf || !size) return 0; if (!m_soft_connected(func_name) || !buf || !size) return 0;
// wait until bearssl is ready to send
if (m_run_until(BR_SSL_SENDAPP) < 0) {
m_error("Failed while waiting for the engine to enter BR_SSL_SENDAPP", func_name);
return 0;
}
// add to the bearssl io buffer, simply appending whatever we want to write // add to the bearssl io buffer, simply appending whatever we want to write
size_t alen; size_t alen;
unsigned char *br_buf = br_ssl_engine_sendapp_buf(&m_sslctx.eng, &alen); unsigned char *br_buf = br_ssl_engine_sendapp_buf(&m_sslctx.eng, &alen);
size_t cur_idx = 0; size_t cur_idx = 0;
if (alen == 0) {
m_error("BearSSL returned zero length buffer for sending, did an internal error occur?", func_name);
return 0;
}
// while there are still elements to write // while there are still elements to write
while (cur_idx < size) { while (cur_idx < size) {
// if we're about to fill the buffer, we need to send the data and then wait // if we're about to fill the buffer, we need to send the data and then wait